simplify SizeError
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit
1. makes `SizeError` struct with one generic field, instead of `enum<T> { Less(usize, T), Greater(usize, T) }`
2. removes `SizeError::{expect,expect_size}` methods
3. changes `Display` output to just "wrong size"
This is done to make API clearer and remove overhead on errors caused by calculating the difference between sizes
WaffleLapkin
force-pushed
the
simplify_size_error
branch
from
387125e to
b3b08ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit
SizeErrorstruct with one generic field, instead ofenum<T> { Less(usize, T), Greater(usize, T) }SizeError::{expect,expect_size}methodsDisplayoutput to just "wrong size"This is done to make API clearer and remove overhead on errors caused by calculating the difference between sizes