Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Rename namespace to "totw_r" or similar #17

Closed
1 task done
xPand4B opened this issue Apr 20, 2022 · 1 comment
Closed
1 task done

[Bug]: Rename namespace to "totw_r" or similar #17

xPand4B opened this issue Apr 20, 2022 · 1 comment
Assignees
@xPand4B
Labels
breaking change Something that is a breaking change bug Something isn't working

Comments

@xPand4B
Copy link
Member

xPand4B commented Apr 20, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Description

Origin from WaldiNet Discord

The namespace towers_of_the_wild_reworked is quite long. If other tower types (ex. ice_glacio) are added (either by me or community contributions) there's a limit on how long these .json and nbt strings can get.

Therefore, the namespace should be shortened to something like totw_r.

To Reproduce

Expected behavior

Mod Version

v3.0.0

Minecraft Version

1.18.2

Java Version

Java 17

Fabric Version (only if below v3.0.0)

No response

Relevant log output

No response

Anything else?

https://discord.com/channels/908438830594527252/908439840075448371/966185119859752992
image
@xPand4B xPand4B added bug Something isn't working breaking change Something that is a breaking change labels Apr 20, 2022
@xPand4B xPand4B self-assigned this Apr 20, 2022
@xPand4B
Copy link
Member Author

xPand4B commented Apr 27, 2022

I think totw_reworked would be the best choice, this way the _r is more meaningful

xPand4B pushed a commit that referenced this issue Apr 28, 2022
GH-17 - Renamed project namespace to totw_reworked
95f29f4 
GH-17 - Renamed datapack namespace from `towers_of_the_wild_reworked` to `totw_reworked`
@xPand4B xPand4B mentioned this issue Apr 28, 2022
Merged
xPand4B pushed a commit that referenced this issue Apr 28, 2022
GH-17 - Renamed data directory
bce72cb
xPand4B pushed a commit that referenced this issue Apr 28, 2022
@celsiusqc
GH-17- Added welpstudent to readme file (#20)
4e918a6
xPand4B added a commit that referenced this issue Apr 28, 2022
@xPand4B @celsiusqc
GH-17 - Renamed project namespace to totw_reworked (#19)
ce4f4d1 
* GH-17 - Renamed project namespace to totw_reworked

* GH-17 - Renamed datapack namespace from `towers_of_the_wild_reworked` to `totw_reworked`

* GH-17 - Renamed data directory

* GH-17- Added welpstudent to readme file (#20)

Co-authored-by: WelpSTudent <63996164+WelpSTudent@users.noreply.github.com>
@xPand4B xPand4B mentioned this issue Apr 28, 2022
Merged
@xPand4B xPand4B closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xPand4B xPand4B

Labels
breaking change Something that is a breaking change bug Something isn't working
Projects
Towers of the Wild: Reworked
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xPand4B