feat: replace wcm with appkit, create options mapping function #5564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomiir
commented
Dec 19, 2024
Comment on lines
+10
to
+22
| return { | ||
| '--w3m-font-family': wcmTheme['--wcm-font-family'], | ||
| '--w3m-accent': wcmTheme['--wcm-accent-color'], | ||
| '--w3m-color-mix': wcmTheme['--wcm-background-color'], | ||
| '--w3m-z-index': wcmTheme['--wcm-z-index'] ? Number(wcmTheme['--wcm-z-index']) : undefined, | ||
|
|
||
| '--w3m-qr-color': wcmTheme['--wcm-accent-color'], | ||
|
|
||
| // Optional: Set master controls for sizing | ||
| '--w3m-font-size-master': wcmTheme['--wcm-text-medium-regular-size'], | ||
| '--w3m-border-radius-master': wcmTheme['--wcm-container-border-radius'], | ||
| '--w3m-color-mix-strength': 8 // Default value, adjust as needed | ||
| }; |
There was a problem hiding this comment.
This is tricky as there is no 1<>1 mapping on these variables. A lot of customization options are not available and implementing in AppKit is not straightforward.
Approach in appkit is based on color mix while WCM has a bunch of much more specific customizations on texts borders and such.
tomiir
commented
Dec 23, 2024
| }; | ||
|
|
||
| // Add mobile and desktop wallets as custom wallets if provided | ||
| if (wcmConfig.mobileWallets?.length || wcmConfig.desktopWallets?.length) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the change.
Type of change
How has this been tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your configuration.
Fixes/Resolves (Optional)
Please list any issues that are fixed by this PR in the format
#<issue number>. If it fixes multiple issues, please put each issue in a separate line. If this Pull Request does not fix any issues, please delete this section.Examples/Screenshots (Optional)
Please attach a screenshot or screen recording of features/fixes you've implemented to verify your changes. Please also note any relevant details for your configuration. If your changes do not affect the UI, please delete this section.
Use this table template to show examples of your changes:
Checklist
Additional Information (Optional)
Please include any additional information that may be useful for the reviewer.