Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update SingleSubjectConcat with frame selection; update MSMAll pipeline #250

Closed
wants to merge 1 commit into from
Closed

Conversation

cyang31
Copy link
Contributor

@cyang31 cyang31 commented Mar 7, 2023

This is the squash and merge version of a previous PR

Background

Previously the script SingleSubjectConcat.sh doesn't enable the frame range selection for each fMRI runs. Hence, the MSMAll is limited to be only applied to the full timeseries.

Main changes

  • replace the old opt with Tim's newopt library in SingleSubjectConcat.sh;
  • remove the bias correction and computation of VN files in SingleSubjectConcat.sh;
  • add two optional arguments StartFrame and EndFrame in SingleSubjectConcat.sh and MSMAllPipeline.sh;
  • validate the input frame range and throw an error if invalid range is provided in SingleSubjectConcat.sh;

Evaluation

One subject with resting state fMRI is evaluated. No error.

Copy link
Contributor

@glasserm glasserm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget, is this fully tested? If so we might just merge this one.

@cyang31
Copy link
Contributor Author

cyang31 commented Mar 7, 2023

I forget, is this fully tested? If so we might just merge this one.
Yes, it has been fully tested.

@coalsont
Copy link
Member

coalsont commented Mar 7, 2023

Let's use the original one, so we don't need to compare whether this one has completely identical changes.

@coalsont coalsont closed this Mar 7, 2023
@cyang31 cyang31 deleted the frame_squash_merge branch March 7, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants