Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace os library with pathlib in workflow scripts #47

Merged
merged 8 commits into from
May 10, 2023

Conversation

axiomcura
Copy link
Member

@axiomcura axiomcura commented May 8, 2023

About this PR

This PR replaces the os library with pathlib in the workflow scripts.

@axiomcura axiomcura changed the title Refactor scripts Replace os library with pathlib in workflow scripts May 9, 2023
@axiomcura axiomcura marked this pull request as ready for review May 9, 2023 19:46
Copy link
Member

@MikeLippincott MikeLippincott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a lot of comments from me. LGTM, ready to merge.

workflows/scripts/aggregate_cells.py Outdated Show resolved Hide resolved
workflows/scripts/annotate.py Show resolved Hide resolved
@axiomcura axiomcura requested a review from d33bs May 9, 2023 20:03
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left a few comments and suggestions with this review, please don't hesitate to reach out if I may clarify at all. Overall things LGTM.

workflows/scripts/aggregate_cells.py Outdated Show resolved Hide resolved
workflows/scripts/aggregate_cells.py Outdated Show resolved Hide resolved
workflows/scripts/consensus.py Show resolved Hide resolved
workflows/scripts/merge_logs.py Show resolved Hide resolved
@axiomcura
Copy link
Member Author

Applied all changes. Merging!

@axiomcura axiomcura merged commit d44985b into WayScience:main May 10, 2023
@axiomcura axiomcura deleted the refactor-scripts branch May 19, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants