-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Select Implementation to CytoPipe #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor comments. Once you address them all, feel free to merge!
|
||
rule create_consensus: | ||
input: | ||
expand( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: beyond scope of this PR
sometimes we want to create consensus profiles from more than just feature selected files.
We may also want to perform feature selection on all profiles (instead of just by plate).
How would this work? (we can discuss later too, but just something to keep in mind)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrote it down on my notes ! I'll see what snakemake has to offer!
Based on my current knowledge this, seems this can be done at the configuration level. We can provide a flag indicating the types of consensus we want and the script can handle it.
In addition, I feel that the consensus step is general enough to create a modular function and call it when we are generating different consensus files.
Hello @gwaygenomics
This PR focuses on the feature select implementation. The new files created in this PR are:
consensus.py
feature_select.py
feature_select.smk