Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CytoSnake Bug Fixes From Cell-Health Data Usage #87

Merged
merged 13 commits into from
Sep 1, 2023

Conversation

axiomcura
Copy link
Member

modified from EmbeddedArtistry

Description

Thank you for your contribution to CytoSnake!
Please succinctly summarize your proposed change.
What motivated you to make this change?

Please also link to any relevant issues that your code is associated with.

This PR fixes bugs that were found and squashed on the cell-health dataset when using CytoSnake locally.

The next step is to make a release after this PR is merged, and use it as a dependency for the cell-health dataset

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@axiomcura axiomcura changed the title Bug Fixes from cell-health data usage CytoSnake Bug Fixes From Cell-Health Data Usage Sep 1, 2023
Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, mostly typo fixes

configs/wf_configs/cp_process.yaml Outdated Show resolved Hide resolved
workflows/rules/aggregate.smk Show resolved Hide resolved
workflows/rules/aggregate.smk Show resolved Hide resolved
workflows/scripts/aggregate_cells.py Outdated Show resolved Hide resolved
workflows/scripts/aggregate_cells.py Outdated Show resolved Hide resolved
workflows/scripts/aggregate_cells.py Outdated Show resolved Hide resolved
axiomcura and others added 3 commits September 1, 2023 16:06
Co-authored-by: Gregory Way <gregory.way@gmail.com>
Co-authored-by: Gregory Way <gregory.way@gmail.com>
@axiomcura axiomcura merged commit 3cd8051 into WayScience:main Sep 1, 2023
@axiomcura
Copy link
Member Author

Alright all comments have been addressed! Merging !

@axiomcura axiomcura deleted the bug-fixes branch October 19, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants