Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CytoDataFrame dependency; remove migrated code #121

Merged
merged 8 commits into from
Nov 5, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Nov 1, 2024

Description

This PR adds CytoDataFrame as a dependency to the project, which is now a migrated independent project. Alongside this I removed code which has been migrated and added a check for dead code through vulture and pre-commit. Some minor formatting changes were also applied through an update to pre-commit checks.

Closes #108

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@d33bs d33bs marked this pull request as ready for review November 1, 2024 22:42
@d33bs d33bs requested a review from jenna-tomkinson November 1, 2024 22:42
Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

media/coverage-badge.svg Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@d33bs
Copy link
Member Author

d33bs commented Nov 5, 2024

Thanks @jenna-tomkinson ! Merging this in.

@d33bs d33bs merged commit 8c2e3a2 into WayScience:main Nov 5, 2024
9 checks passed
@d33bs d33bs deleted the cytodataframe-dep branch November 5, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate CytoDataFrame to separate project
2 participants