Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cytodataframe.show_report references #153

Merged
merged 3 commits into from
Dec 15, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Dec 10, 2024

Description

Earlier revisions of cosmicqc leveraged functionality in cytodataframe to display plotly plots through a method called show_report. This functionality no longer exists within cytodataframe and would result in an error if someone tried to use it through cosmicqc. This PR removes those references.

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@d33bs d33bs changed the title Remove cytodataframe show_report references Remove cytodataframe.show_report references Dec 10, 2024
@d33bs d33bs marked this pull request as ready for review December 10, 2024 17:20
Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Removing it is probably for the best, but I think we can come back to it again in the future if we think of something else to improve upon it.

@d33bs
Copy link
Member Author

d33bs commented Dec 15, 2024

Thanks Jenna! Merging this in.

@d33bs d33bs merged commit 6aa896a into WayScience:main Dec 15, 2024
9 checks passed
@d33bs d33bs deleted the remove-report branch December 15, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants