Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poetry-dynamic-versioning for PyPI builds #29

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Jun 5, 2024

Description

This PR adds poetry-dynamic-versioning for automated PyPI builds in order to ensure the proper version is used. Without this, the version won't be inferred properly on PyPI.

Closes #27

What kind of change(s) are included?

  • Feature (adds or updates new capabilities)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs requested a review from jenna-tomkinson June 5, 2024 17:25
Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 Nice small PR!

.github/workflows/publish-pypi.yml Show resolved Hide resolved
@d33bs
Copy link
Member Author

d33bs commented Jun 6, 2024

Thanks @jenna-tomkinson for the review!

@d33bs d33bs merged commit b90c5c1 into WayScience:main Jun 6, 2024
11 checks passed
@d33bs d33bs deleted the fix-pypi-releases branch June 6, 2024 19:56
@d33bs d33bs added the release-patch Creates a patch release (e.g. `v0.0.1`) label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Creates a patch release (e.g. `v0.0.1`)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix PyPI semver specification in deployments
2 participants