-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add report generation capabilities #39
Conversation
Co-authored-by: Gregory Way <gregory.way@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool to see this! Maybe beyond scope of this PR, but I think it would be nice to have an option to export to PDF as well (in addition to HTML option)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left some general comments but the code looks to be good! Super exciting! 🎉
Co-Authored-By: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
Thanks Greg and Jenna for your reviews! I've addressed all the comments and will now merge this in. |
Description
This PR addresses #2 by adding report generation capabilities for
coSMicQC
. To do this I had to modify the dataframe schema of added columns which incurred other changes throughout. Generally I thought this would be helpful to include as part of theSCDataFrame
class to help keep things tidy. I tried to keep the visualization flexible to any possible set of thresholds based on the existing defaults (trying to plan ahead and be flexible).This should be reviewed and merged after #34
Preview of the report in Jupyter notebook:
Preview of the report in HTML (for CLI or export):
Closes #2
Closes #22
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.