Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull request template #68

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Aug 7, 2024

Description

This PR makes a small change to the PR templates. I felt that "feature" and "enhancement" are overlapping, and that there's no documentation option, so replaced one of the checkbox options. I've manually adjusted the content found within this PR description.

Thanks for any feedback you may have!

What kind of change(s) are included?

  • Documentation
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs requested a review from jenna-tomkinson August 7, 2024 17:16
Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, makes it clearer that a new function/feature is an enhancement. LGTM!

@d33bs
Copy link
Member Author

d33bs commented Aug 8, 2024

Thanks @jenna-tomkinson! Merging this in.

@d33bs d33bs merged commit 19cefa4 into WayScience:main Aug 8, 2024
11 checks passed
@d33bs d33bs deleted the fix-pr-template branch August 8, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants