Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Well Sampling #27

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Updated Well Sampling #27

merged 2 commits into from
Mar 11, 2024

Conversation

MattsonCam
Copy link
Member

@MattsonCam MattsonCam commented Mar 11, 2024

In this pr, I use the dp solution to select entire test wells for the non-minority groups until selecting additional test wells would change the minority group in the train/validation dataset. This consists of finding the largest number of cells that can be added for a given capacity of cells and number of wells, where cell capacities are restricted by well cell count. Please let me know if you have any questions or suggestions.

Copy link
Member

@MikeLippincott MikeLippincott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice PR. LGTM

1.train_models/utils/WellSubsetSum.py Outdated Show resolved Hide resolved
1.train_models/utils/WellSubsetSum.py Outdated Show resolved Hide resolved
1.train_models/utils/WellSubsetSum.py Show resolved Hide resolved
@MattsonCam
Copy link
Member Author

Thanks @MikeLippincott, merging now!

@MattsonCam MattsonCam merged commit 542a796 into main Mar 11, 2024
@MattsonCam MattsonCam deleted the update_test_well_sampling branch March 11, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants