Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize logistic regression plates 3, 3 prime, and 5 #28

Merged
merged 15 commits into from
Mar 23, 2024

Conversation

MattsonCam
Copy link
Member

In this pr, a random search of the regularization parameter is performed using data from plates 3, 3 prime, and 5. The final model is then trained on all of the cross-validated data and saved. The folds and data splits used for optimization were also saved for later evaluation of training and validation data. Please let me know if you have any suggestions.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@MattsonCam MattsonCam requested a review from d33bs March 18, 2024 23:50
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I'm requesting changes mostly due to what looked like a misalignment in file naming for a parquet export labeled as a .joblib. Once that's in place, please feel free to re-request a review. All other comments are up for your consideration. Please don't hesitate to let me know if you have any questions along the way.

@MattsonCam MattsonCam requested a review from d33bs March 20, 2024 19:51
@MattsonCam
Copy link
Member Author

MattsonCam commented Mar 20, 2024

Hey @d33bs, actually, I may add something to this pr, so could you wait to provide a re-review?

@d33bs
Copy link
Member

d33bs commented Mar 21, 2024

Thanks @MattsonCam! I'll wait for your go-ahead here on a re-review.

@MattsonCam
Copy link
Member Author

Thanks @MattsonCam! I'll wait for your go-ahead here on a re-review.

Thanks for waiting @d33bs, it's ready now!

Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I left a few comments which might need a look but overall thought things looked good. Please don't hesitate to let me know if you have any questions.

@MattsonCam
Copy link
Member Author

Thanks @d33bs, merging now!

@MattsonCam MattsonCam merged commit 7cca6f5 into main Mar 23, 2024
@MattsonCam MattsonCam deleted the train_plates_3_3p_5_log_reg branch March 23, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants