Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated shuffled model evaluation data #32

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

MattsonCam
Copy link
Member

@MattsonCam MattsonCam commented Mar 26, 2024

In this pr, the shuffled model evaluation data is computed and stored. Please let me know if you have any suggestions. The code comes from pr #30.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused what changed in this PR if no code changed? Oh, maybe you're just adding the shuffled results? Can you change the title of the PR to specify that you're adding data that were already generated, if so. It would also be helpful to link the relevant PR where you added the code that generated this data.

@MattsonCam MattsonCam changed the title Shuffled model evaluation data Generated Shuffled model evaluation data Mar 27, 2024
@MattsonCam MattsonCam changed the title Generated Shuffled model evaluation data Generated shuffled model evaluation data Mar 27, 2024
@MattsonCam
Copy link
Member Author

MattsonCam commented Mar 27, 2024

I'm a bit confused what changed in this PR if no code changed? Oh, maybe you're just adding the shuffled results? Can you change the title of the PR to specify that you're adding data that were already generated, if so. It would also be helpful to link the relevant PR where you added the code that generated this data.

Correct, I didn't modify the code, just the data. I also included a link to the pr with the code in the initial comment.

@MattsonCam
Copy link
Member Author

Thanks @gwaybio, merging now!

@MattsonCam MattsonCam merged commit a10e94c into main Mar 27, 2024
@MattsonCam MattsonCam deleted the evaluate_shuffled branch March 27, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants