Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main figure 3 #55

Merged

Conversation

jenna-tomkinson
Copy link
Member

Update main figure 3

In this PR, main figure 3 is updated to include the new model results. Small documentation changes were added to README related to the data used in this figure, to simplify and provide further clarity.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@MattsonCam MattsonCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jenna-tomkinson, just some minor comments. Good job!

2.evaluate_model/README.md Outdated Show resolved Hide resolved
3.figures/figures/main_figure_3_model_eval.png Outdated Show resolved Hide resolved
@jenna-tomkinson
Copy link
Member Author

@MattsonCam Thanks for the review! I am merging now!

@jenna-tomkinson jenna-tomkinson merged commit bd0d34a into WayScience:main Aug 1, 2024
@jenna-tomkinson jenna-tomkinson deleted the update_main_figure_3 branch August 1, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants