Update plate correlation analysis #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jenna-tomkinson
requested changes
Jul 31, 2024
There was a problem hiding this comment.
I am requesting changes for the PR as the parquet file with the correlations data is not included, only removed. It looks like a small issue with the to_parquet function where it isn't saved.
Feel free to let me know when it is fixed and it will be an easy approve!
0.data_analysis/plate_correlation_analyses/well_agg_plate_genotype_correlation_analysis.py
Outdated
Show resolved
Hide resolved
0.data_analysis/plate_correlation_analyses/well_agg_plate_genotype_correlation_analysis.py
Outdated
Show resolved
Hide resolved
...ates_characteristics/construct_correlation_data/concatenated_all_plates_correlations.parquet
Outdated
Show resolved
Hide resolved
...lysis/plate_correlation_analyses/nbconverted/well_agg_plate_genotype_correlation_analysis.py
Outdated
Show resolved
Hide resolved
...lysis/plate_correlation_analyses/nbconverted/well_agg_plate_genotype_correlation_analysis.py
Show resolved
Hide resolved
...lysis/plate_correlation_analyses/nbconverted/well_agg_plate_genotype_correlation_analysis.py
Show resolved
Hide resolved
...lysis/plate_correlation_analyses/nbconverted/well_agg_plate_genotype_correlation_analysis.py
Outdated
Show resolved
Hide resolved
...lysis/plate_correlation_analyses/nbconverted/well_agg_plate_genotype_correlation_analysis.py
Outdated
Show resolved
Hide resolved
|
Thanks for the comments @jenna-tomkinson! Re-requesting a review |
jenna-tomkinson
approved these changes
Aug 1, 2024
|
Thanks @jenna-tomkinson, merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, the plate correlation analysis and corresponding README are updated using the recently updated analysis utils. Correlations are computed from cell morphology features aggregated to the well level. Feel free to add any constructive feedback you may have while reviewing this pr.