Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch over to Danger-Swift & Bitrise #34

Merged
merged 3 commits into from
Jan 22, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions .jazzy.yaml

This file was deleted.

14 changes: 0 additions & 14 deletions .travis.yml

This file was deleted.

5 changes: 5 additions & 0 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# https://help.github.com/en/articles/about-code-owners
# These owners will be the default owners for everything in
# the repo. Unless a later match takes precedence, they
# will be requested for review when someone opens a PR.
* @Boris-Em @kairadiagne @AvdLee
4 changes: 0 additions & 4 deletions Changelog.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
## Changelog

### Next
- `MockingURLProtocol` Error now conforms to `CustomDebugStringConvertible` for better debugging logs.
- Fixed a bug in which two Mocks would not be registered for the same URL if the HTTP method was different.

### 2.0.0
- A new completion callback can be set on `Mock` to use for expectation fulfilling once a `Mock` is completed.
- A new onRequest callback can be set on `Mock` to use for expectation fulfilling once a `Mock` is requested.
Expand Down
4 changes: 4 additions & 0 deletions Dangerfile.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import Danger
import WeTransferPRLinter

WeTransferPRLinter.lint()
15 changes: 2 additions & 13 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,15 +1,4 @@
# frozen_string_literal: true
source "https://rubygems.org"

# Needed for Fastlane & Danger
gem 'danger'
gem 'danger-junit'
gem 'danger-swiftlint'
gem 'danger-xcode_summary'
gem 'danger-xcov'
gem 'fastlane'
gem 'xcpretty'
gem 'xcpretty-json-formatter'

plugins_path = File.join(File.dirname(__FILE__), 'fastlane', 'Pluginfile')
eval_gemfile(plugins_path) if File.exist?(plugins_path)
ci_gems_path = File.join(File.dirname(__FILE__), "Submodules/WeTransfer-iOS-CI/Gemfile")
eval_gemfile(ci_gems_path) if File.exist?(ci_gems_path)
16 changes: 12 additions & 4 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,16 @@ let package = Package(name: "Mocker",
.iOS(.v10),
.tvOS(.v12),
.watchOS(.v6)],
products: [.library(name: "Mocker",
targets: ["Mocker"])],
targets: [.target(name: "Mocker",
path: "Sources")],
products: [
.library(name: "DangerDeps", type: .dynamic, targets: ["DangerDependencies"]), // dev
.library(name: "Mocker", targets: ["Mocker"])
],
dependencies: [
.package(url: "https://github.com/danger/swift", from: "3.0.0"), // dev
.package(path: "Submodules/WeTransfer-iOS-CI/Danger-Swift") // dev
],
targets: [
.target(name: "Mocker", path: "Sources"),
.target(name: "DangerDependencies", dependencies: ["Danger", "WeTransferPRLinter"], path: "Submodules/WeTransfer-iOS-CI/Danger-Swift", sources: ["DangerFakeSource.swift"]) // dev
],
swiftLanguageVersions: [.v5])
2 changes: 1 addition & 1 deletion Submodules/WeTransfer-iOS-CI
Submodule WeTransfer-iOS-CI updated 39 files
+7 −1 .gitignore
+0 −3 .rspec
+0 −7 .travis.yml
+ Assets/runscript.png
+73 −0 Bitrise/bitrise.yml
+4 −1 Changelog.md
+5 −0 Danger-Swift/.gitignore
+3 −0 Danger-Swift/DangerFakeSource.swift
+79 −0 Danger-Swift/Package.resolved
+28 −0 Danger-Swift/Package.swift
+37 −0 Danger-Swift/Sources/WeTransferPRLinter/CoverageReporter.swift
+24 −0 Danger-Swift/Sources/WeTransferPRLinter/SwiftLintExecutor.swift
+199 −0 Danger-Swift/Sources/WeTransferPRLinter/WeTransferPRLinter.swift
+55 −0 Danger-Swift/Sources/WeTransferPRLinter/XcodeSummaryReporter.swift
+33 −0 Danger-Swift/Tests/WeTransferPRLinterTests/TestHelpers/DangerTestExtensions.swift
+36 −0 Danger-Swift/Tests/WeTransferPRLinterTests/TestHelpers/Mocks.swift
+2,131 −0 Danger-Swift/Tests/WeTransferPRLinterTests/TestHelpers/TestGithubDSL.swift
+51 −0 Danger-Swift/Tests/WeTransferPRLinterTests/TestHelpers/TestXcodeSummaryJSON.swift
+331 −0 Danger-Swift/Tests/WeTransferPRLinterTests/WeTransferLinterTests.swift
+9 −0 Danger-Swift/Tests/WeTransferPRLinterTests/XCTestManifests.swift
+0 −209 Danger/DangerTests.swift
+0 −115 Danger/Dangerfile
+0 −14 Danger/ext/.rubocop.yml
+0 −115 Danger/ext/git_swift_linter.rb
+0 −18 Dangerfile
+4 −0 Dangerfile.swift
+113 −11 Fastlane/Fastfile
+3 −8 Gemfile
+165 −0 Gemfile.lock
+79 −0 Package.resolved
+19 −0 Package.swift
+52 −62 README.md
+0 −6 Scripts/travis.sh
+6 −11 SwiftLint/.swiftlint-source.yml
+3 −2 SwiftLint/.swiftlint-tests.yml
+11 −0 SwiftLint/swiftlint.sh
+0 −11 spec/.rubocop.yml
+0 −237 spec/git_swift_linter_spec.rb
+0 −37 spec/spec_helper.rb
137 changes: 0 additions & 137 deletions docs/Classes.html

This file was deleted.

Loading