Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure file extension mocks are matching correctly #95

Merged
merged 2 commits into from
Apr 22, 2021

Conversation

AvdLee
Copy link
Contributor

@AvdLee AvdLee commented Apr 21, 2021

Mocks targetting file extensions weren't matching correctly.

@AvdLee AvdLee requested a review from kairadiagne April 21, 2021 15:42
@AvdLee AvdLee self-assigned this Apr 21, 2021
@AvdLee AvdLee requested a review from Boris-Em as a code owner April 21, 2021 15:42
@wetransferplatform
Copy link
Collaborator

wetransferplatform commented Apr 21, 2021

Warnings
⚠️

Consider to place some MARK: lines for Sources/Mock.swift, which is over 200 lines big.

Messages
📖

View more details on Bitrise

📖 Mocker: Executed 25 tests, with 0 failures (0 unexpected) in 1.748 (1.888) seconds

Mocker.framework: Coverage: 88.04

File Coverage
Mock.swift 82.18%

Generated by 🚫 Danger Swift against 7cb9a50

@AvdLee AvdLee merged commit d245ac3 into master Apr 22, 2021
@AvdLee AvdLee deleted the feature/mock-matching branch April 22, 2021 14:33
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 2.5.3 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants