Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new max width setting #43

Merged
merged 3 commits into from
Jul 19, 2019
Merged

Add a new max width setting #43

merged 3 commits into from
Jul 19, 2019

Conversation

AvdLee
Copy link
Contributor

@AvdLee AvdLee commented Jul 18, 2019

  • Updated the example project to Swift 5.0.
  • Example project builds again
  • Max width setting is now available

Fixes #41

@AvdLee AvdLee requested a review from Boris-Em July 18, 2019 12:23
@AvdLee AvdLee self-assigned this Jul 18, 2019
@ghost
Copy link

ghost commented Jul 18, 2019

2 Warnings
⚠️ Sources/UINotificationView.swift#L75 - It is safer to use weak instead of unowned
⚠️ Sources/UINotificationView.swift#L82 - It is safer to use weak instead of unowned
1 Message
📖 Executed 22 tests, with 0 failures (0 unexpected) in 2.453 (2.578) seconds

Current coverage for UINotifications is 97.06%

Files changed - -
UINotificationView.swift 94.52% ✅
UINotificationPresentationContext.swift 95.77% ✅
UINotification.swift 96.67% ✅
UINotificationSystemStyle.swift 100.00% ✅

Powered by xcov

Generated by 🚫 Danger

Boris-Em
Boris-Em approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@Boris-Em Boris-Em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@AvdLee AvdLee merged commit acb7358 into master Jul 19, 2019
@AvdLee AvdLee deleted the feature/max-width branch July 19, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boris-Em Boris-Em Boris-Em approved these changes

Assignees

@AvdLee AvdLee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of undeclared type 'UINotificationHeight' in Example project
2 participants
@AvdLee @Boris-Em