Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SwiftLint, update CI, update to Swift 5.0 #45

Merged
merged 5 commits into from
Aug 7, 2019

Conversation

AvdLee
Copy link
Contributor

@AvdLee AvdLee commented Aug 7, 2019

SwiftLint rules are updated. As well, CI is now reporting failing tests correctly and the example projects are Swift 5.0

@AvdLee AvdLee self-assigned this Aug 7, 2019
@ghost
Copy link

ghost commented Aug 7, 2019

2 Warnings
⚠️ Sources/UINotificationView.swift#L75 - It is safer to use weak instead of unowned
⚠️ Sources/UINotificationView.swift#L82 - It is safer to use weak instead of unowned
1 Message
📖 Errors: Executed 22 tests, with 0 failures (0 unexpected) in 2.398 (2.570) seconds

Current coverage for UINotifications.framework is 97.06%

Files changed - -
UINotificationView.swift 94.52%
UINotification.swift 96.67%
UINotificationQueue.swift 100.00%
UINotificationRequest.swift 100.00%

Powered by xcov

Generated by 🚫 Danger

Copy link
Contributor

@kairadiagne kairadiagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@AvdLee AvdLee merged commit eb9f1ff into master Aug 7, 2019
@AvdLee AvdLee deleted the feature/update-swiftlint branch August 7, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants