Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UINotificationStyle conform to main actor #76

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

AvdLee
Copy link
Contributor

@AvdLee AvdLee commented Jan 23, 2024

This became a requirement for the WeTransfer project and actually makes sense if you think about it, since we're working with UI notifications.

@wetransferplatform
Copy link
Collaborator

wetransferplatform commented Jan 23, 2024

Messages
📖 UINotificationsTests: Executed 25 tests (0 failed, 0 retried, 0 skipped) in 2.633 seconds
📖 Slowest test: UINotificationDefaultElementsTests/testEaseOutEaseInPresenter() (2.423s)
📖

View more details on Bitrise

Code Coverage Report

Name Coverage
UINotifications 98.04%

SwiftLint found issues

Severity File Reason
Warning UINotificationTestCase.swift:14 Consider using final for this class, or use a struct (final_class)
Warning UINotificationTestCase.swift:24 Variables should not have redundant type annotation (redundant_type_annotation)
Warning UINotificationTestCase.swift:25 Variables should not have redundant type annotation (redundant_type_annotation)
Warning UINotificationTestCase.swift:50 Variables should not have redundant type annotation (redundant_type_annotation)
Warning UINotificationTestCase.swift:53 Variables should not have redundant type annotation (redundant_type_annotation)
Warning UINotificationTestCase.swift:54 Variables should not have redundant type annotation (redundant_type_annotation)
Warning UINotificationTestCase.swift:11 Imports should be sorted (sorted_imports)
Warning UINotificationTestCase.swift:16 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationTestCase.swift:19 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationTestCase.swift:23 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationTestCase.swift:26 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationTestCase.swift:38 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationTestCase.swift:45 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationTestCase.swift:47 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationTestCase.swift:52 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationTestCase.swift:55 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationTestCase.swift:60 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationTestCase.swift:66 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationTestCase.swift:71 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationTestCase.swift:74 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationTestCase.swift:79 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationTestCase.swift:83 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationTestCase.swift:15 An 'instance_property' should not be placed amongst the type content(s) 'subtype' (type_contents_order)
Warning UINotificationQueueTests.swift:70 Line should be 140 characters or less; currently it has 157 characters (line_length)
Warning UINotificationQueueTests.swift:10 Imports should be sorted (sorted_imports)
Warning UINotificationQueueTests.swift:13 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationQueueTests.swift:20 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationQueueTests.swift:28 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationQueueTests.swift:35 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationQueueTests.swift:42 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationQueueTests.swift:48 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationQueueTests.swift:60 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotificationQueueTests.swift:18 Prefer the specific matcher 'XCTAssertEqual' instead (xct_specific_matcher)
Warning UINotificationQueueTests.swift:26 Prefer the specific matcher 'XCTAssertEqual' instead (xct_specific_matcher)
Warning UINotificationQueueTests.swift:33 Prefer the specific matcher 'XCTAssertEqual' instead (xct_specific_matcher)
Warning UINotificationQueueTests.swift:43 Prefer the specific matcher 'XCTAssertEqual' instead (xct_specific_matcher)
Warning UINotificationQueueTests.swift:44 Prefer the specific matcher 'XCTAssertEqual' instead (xct_specific_matcher)
Warning UINotificationQueueTests.swift:45 Prefer the specific matcher 'XCTAssertEqual' instead (xct_specific_matcher)
Warning UINotificationQueueTests.swift:46 Prefer the specific matcher 'XCTAssertEqual' instead (xct_specific_matcher)
Warning UINotificationQueueTests.swift:54 Prefer the specific matcher 'XCTAssertEqual' instead (xct_specific_matcher)
Warning UINotificationQueueTests.swift:56 Prefer the specific matcher 'XCTAssertEqual' instead (xct_specific_matcher)
Warning UINotificationQueueTests.swift:58 Prefer the specific matcher 'XCTAssertEqual' instead (xct_specific_matcher)
Warning UINotificationQueueTests.swift:66 Prefer the specific matcher 'XCTAssertEqual' instead (xct_specific_matcher)
Warning UINotificationQueueTests.swift:68 Prefer the specific matcher 'XCTAssertEqual' instead (xct_specific_matcher)
Warning UINotificationQueueTests.swift:69 Prefer the specific matcher 'XCTAssertEqual' instead (xct_specific_matcher)
Warning UINotificationQueueTests.swift:71 Prefer the specific matcher 'XCTAssertEqual' instead (xct_specific_matcher)
Warning UINotificationQueueTests.swift:72 Prefer the specific matcher 'XCTAssertEqual' instead (xct_specific_matcher)
Warning UINotification.swift:110 Operators should be surrounded by a single whitespace when they are being used (operator_usage_whitespace)
Warning UINotification.swift:25 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotification.swift:31 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotification.swift:34 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotification.swift:37 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotification.swift:47 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotification.swift:91 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotification.swift:101 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotification.swift:106 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotification.swift:123 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotification.swift:132 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotification.swift:135 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotification.swift:138 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotification.swift:144 Lines should not have trailing whitespace (trailing_whitespace)
Warning UINotification.swift:56 A 'type_property' should not be placed amongst the type content(s) 'subtype' (type_contents_order)

Generated by 🚫 Danger Swift against 8af57e2

@AvdLee AvdLee merged commit dfedd79 into master Jan 25, 2024
2 checks passed
@AvdLee AvdLee deleted the feature/notification-style-main-actor branch January 25, 2024 14:24
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 2.1.0 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants