Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop: 1.21.0 → 1.22.2 (minor) #57

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Update rubocop: 1.21.0 → 1.22.2 (minor) #57

merged 1 commit into from
Oct 27, 2021

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Oct 23, 2021

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.21.0 → 1.22.2) · Repo · Changelog

Release Notes

1.22.2

Bug fixes

  • #10165: Fix Layout/DotPosition false positives when the selector and receiver are on the same line. (@dvandersluis)
  • #10171: Fix Style/HashTransformKeys and Style/HashTransformValues incorrect auto-correction when inside block body. (@franzliedke)
  • #10180: Fix an error for Style/SelectByRegexp when using match? without a receiver. (@koic)
  • #10193: Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords when begin and rescue are on the same line. (@koic)
  • #10185: Fix a false positive for Lint/AmbiguousRange when using self in a range literal. (@koic)
  • #10200: Fix an error when inspecting a directory named *. (@koic)
  • #10149: Fix Bundler/GemComment where it would not detect an offense in some cases when OnlyFor is set to restrictive_version_specifiers. (@Drowze)

Changes

  • #10157: Updated Gemspec/RequiredRubyVersion handle being set to blank values. (@dvandersluis)
  • #10176: Unmark AutoCorrect: false from Security/JSONLoad. (@koic)
  • #10186: Explicit block arg is not counted for Metrics/ParameterLists. (@koic)

1.22.1

Bug fixes

  • #10143: Fix an error for Lint/RequireRelativeSelfPath when using a variable as an argument of require_relative. (@koic)
  • #10140: Fix false positive for Layout/DotPosition when a heredoc receives a method on the same line as the start sigil in trailing style. (@dvandersluis)
  • #10148: Fix Style/QuotedSymbols handling escaped characters incorrectly. (@dvandersluis)
  • #10145: Update Style/SelectByRegexp to ignore cases where the receiver appears to be a hash. (@dvandersluis)

1.22.0

New features

Bug fixes

  • #10110: Update Layout/DotPosition to be able to handle heredocs. (@dvandersluis)
  • #10134: Update Style/MutableConstant to not consider multiline uninterpolated strings as unfrozen in ruby 3.0. (@dvandersluis)
  • #10124: Fix Layout/RedundantLineBreak adding extra space within method chains. (@dvandersluis)
  • #10118: Fix crash with Style/RedundantSort when the block doesn't only contain a single send node. (@dvandersluis)
  • #10135: Fix Style/WordArray to exclude files in --auto-gen-config when percent style is given but brackets are required. (@dvandersluis)
  • #10090: Fix a false negative for Style/ArgumentsForwarding when using only kwrest arg. (@koic)
  • #10099: UpdateStyle/RedundantFreeze to stop considering ENV values as immutable. (@byroot)
  • #10078: Fix Layout/LineLength reported length when ignoring directive comments. (@dvandersluis)
  • #9934: Fix configuration loading to not raise an error for an obsolete ruby version that is subsequently overridden. (@dvandersluis)
  • #10136: Update Lint/AssignmentInCondition to not consider assignments within blocks in conditions. (@dvandersluis)
  • #9588: Fix causing a variable to be shadowed from outside the rescue block in the logic of Naming/RescuedExceptionsVariableName. (@lilisako)
  • #10096: Fix Lint/AmbiguousOperatorPrecedence with and/or operators. (@dvandersluis)
  • #10106: Fix Style/RedundantSelf for pattern matching. (@dvandersluis)
  • #10066: Fix how MinDigits is calculated for Style/NumericLiterals when generating a configuration file. (@dvandersluis)

Changes

  • #10088: Update Lint/BooleanSymbol to be SafeAutoCorrect: false rather than Safe: false. (@dvandersluis)
  • #10122: Update Style/RedundantSort to be unsafe, and revert the special case for size from #10061. (@dvandersluis)
  • #10130: Update Lint/ElseLayout to be able to handle an else with only a single line. (@dvandersluis)
  • #8431: Add Safety section to documentation for all cops that are Safe: false or SafeAutoCorrect: false. (@dvandersluis)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rubocop-ast (indirect, 1.11.0 → 1.12.0) · Repo · Changelog

Release Notes

1.12.0 (from changelog)

Bug fixes

  • #208: Update MethodDispatchNode#block_literal? to return true for numblocks. (@dvandersluis)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 6 commits:

↗️ unicode-display_width (indirect, 2.0.0 → 2.1.0) · Repo · Changelog

Release Notes

2.1.0 (from changelog)

  • Unicode 14.0

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 7 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot requested a review from acroos as a code owner October 23, 2021 07:21
@depfu depfu bot added the depfu label Oct 23, 2021
@depfu depfu bot mentioned this pull request Oct 23, 2021
Closed
@acroos acroos merged commit 3cc6f3e into main Oct 27, 2021
@acroos acroos deleted the depfu/update/rubocop-1.22.2 branch October 27, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acroos acroos acroos approved these changes

Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@acroos