Fixes #30, Fixes #34, Fixes #36, #35
Conversation
src/buildVariables.ts
Outdated
| } | ||
| if (!inputType) { | ||
| return acc; | ||
| } |
There was a problem hiding this comment.
i am not sure if there are some cases where we should add the property despite there is no input type.
when key is id is one exception, that's why i moved it on top of the function. But maybe there are other cases?
src/buildVariables.ts
Outdated
| ...data | ||
| } | ||
| }; | ||
| } |
There was a problem hiding this comment.
this part is mostly duplicated from buildUpdateVariables, we should generalize that later
|
@Weakky any chance to get it merged? |
|
@macrozone He doesn't seem to respond. Ran into #36 immediately. +1 |
|
@prestontighe :-( I will fork and publish, if we don't get a response soon. In the meantime i am using https://www.npmjs.com/package/patch-package to apply the patch |
|
@Weakky any chance that you could review this? also we should check compatibility with react-admin 3.0.0. I tried the alpha and it kind-of works, but i have some problems with ReferenceInput |
|
@Weakky any updates or is it possible to get write access to npm and to this repo here, so that the community can take over? |
|
@Weakky we know you guys are busy with prisma2, but couldn't you just take 15mins of your time to review that and maybe release it? i think react-admin integration could be a big leverage for prisma, but i fear it does not get the attention that it should in my opinion |
|
@macrozone Maybe you could ping some of the Prisma guys to nudge him on Slack or something :) You also might be able to find him by joining the Prisma Slack. I remember being able to publicly join the Graphcool Slack awhile back. |
|
Hi @prestontighe @macrozone, https://github.com/marcantoine/ra-data-graphql-prisma I fixed a few queries / mutations but there is still of work to do on it, and i might need your fixes as well :) Since i'm using react-admin with prisma in production, and it might take a while before we can migrate to prisma 2, I think it'd make sense to maintain this module for a couple of year. Feel free to post issues and send PR on the fork! |
|
@marcantoine cool! will check out! |
Fixes #30
Fixes #34
Fixes #36
superseeds #31 because i needed to refactor it a bit