Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pure JS sass to get rid of node-sass #68

Merged
merged 3 commits into from
Nov 24, 2020

Conversation

jfarseneau-wb
Copy link
Contributor

@jfarseneau-wb jfarseneau-wb commented Nov 20, 2020

Summary

Node-sass is a huge pain with compilation, this plays better with other tools and uses pure JS

It also adds source-maps to the CSS for debuggery

Submitter Checklist:

  • Perform self-review (see reviewer checklist)
  • Address reviewer feedback, if any, and assign back to reviewer

Reviewer Checklist:

  • Version bump in package.json
  • Visually review significant UI changes
  • Assign @pez-wb as reviewer if needed
  • Assign back to submitter with feedback

Copy link
Contributor

@pez-work pez-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested w/ WB, PSD, & Valet all appear to work as expected

@jfarseneau-wb
Copy link
Contributor Author

Thanks for the review @pez-wb !

@jfarseneau-wb jfarseneau-wb merged commit 181bfb2 into master Nov 24, 2020
@jfarseneau-wb jfarseneau-wb deleted the fix.switch_to_pure_js_sass branch November 24, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants