Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registry indexing, function calls, global manipulation, now all recursive! #156

Merged
merged 66 commits into from
Sep 13, 2023
Merged

Registry indexing, function calls, global manipulation, now all recursive! #156

merged 66 commits into from
Sep 13, 2023

Conversation

RadiantUwU
Copy link
Contributor

@RadiantUwU RadiantUwU commented Sep 12, 2023 •
edited
Loading

Some nice QoL features

@RadiantUwU
Add get/set registry
4d48a2a
@RadiantUwU
Add to _bind_methods
2a7107c
@RadiantUwU
add get/set registry to luaState.h
0933b12
@RadiantUwU
Implement set/get registry
afbf4c2
@RadiantUwU
Style fix
8b8057d
@RadiantUwU
Update luaAPI.cpp
a1e8cf5
@RadiantUwU
Update luaState.cpp
1c9acaa
@RadiantUwU
Add entries for function related methods in the registry.
da451dd
@RadiantUwU
Implement function registry methods to lua state
5b459e5
@RadiantUwU
Add function registry related methods
bc88974
@RadiantUwU
Implement registry function calls
7d2c382
@RadiantUwU
these bugs ;-;
e0a6c23
@RadiantUwU
brain fart
a324f23 
lmao
@RadiantUwU
Add registry docs
050acc6
@RadiantUwU
Add headers for registry methods
f8b2b28
@RadiantUwU
Implement registry methods.
ef0b299
@RadiantUwU
Merge pull request #1 from RadiantUwU/main
4d2e757 
thankies :333
@RadiantUwU
Update coroutine docs for registry functions.
c90a516
@RadiantUwU
Add shtuff
5d5fe18
@RadiantUwU
im a dum dum
37498d7
@RadiantUwU
Merge pull request #2 from RadiantUwU/editing
71ded41 
Add the table indexing stuff
@RadiantUwU
style fix
56c2e36
@RadiantUwU
bug fix
b4184e8
@RadiantUwU
Make LuaJIT work
b790d9b
@RadiantUwU
Make GDExtension work
2e9b5ca
@RadiantUwU
style fix
f5c46e9
@RadiantUwU
i forgot how c++ works
ec3a9a7
@RadiantUwU
copy pasting was a bad idea
bff82fb
@RadiantUwU
gdextension always breaks stuff :c
930e4e0
@RadiantUwU RadiantUwU marked this pull request as ready for review September 12, 2023 14:26
Trey2k
Trey2k requested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@Trey2k Trey2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of issues still, after these are resolved it should be good for to be merged.

src/classes/luaAPI.cpp Outdated Show resolved Hide resolved
doc_classes/LuaCoroutine.xml Outdated Show resolved Hide resolved
doc_classes/LuaAPI.xml Outdated Show resolved Hide resolved
src/classes/luaCoroutine.cpp Outdated Show resolved Hide resolved
src/luaState.cpp Outdated Show resolved Hide resolved
src/luaState.h Show resolved Hide resolved
@RadiantUwU
Copy link
Contributor Author

fixed issues

Trey2k
Trey2k reviewed Sep 13, 2023
View reviewed changes
src/luaState.h Outdated Show resolved Hide resolved
Trey2k
Trey2k approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@Trey2k Trey2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming checks pass we should be good. Thanks!

@RadiantUwU
Copy link
Contributor Author

uhoh

@RadiantUwU
Copy link
Contributor Author

style fix

@Trey2k
Copy link
Member

Trey2k commented Sep 13, 2023

uhoh

Static checks can be picky

@RadiantUwU
Copy link
Contributor Author

Oops, i went overboard with replacing

@RadiantUwU
Copy link
Contributor Author

Should be fine... hopefully....

@RadiantUwU
Copy link
Contributor Author

I think its gonna be fine

@Trey2k Trey2k merged commit ac5beb3 into WeaselGames:main Sep 13, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trey2k Trey2k Trey2k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RadiantUwU @Trey2k