Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publishing a snapshot #138

Closed
sunfishcode opened this issue Nov 5, 2019 · 7 comments · Fixed by #147
Closed

Publishing a snapshot #138

sunfishcode opened this issue Nov 5, 2019 · 7 comments · Fixed by #147

Comments

@sunfishcode
Copy link
Member

We've had several PRs to the witx files, so it's time to start thinking about making an "unstable" snapshot, according to the phases process.

  • I've gotten feedback from a few folks that "unstable" is confusing. Should we rename "unstable" to "snapshot" while we have a chance here?
  • Are there any issues which are close to being resolved that we should wait for?
@cjihrig
Copy link
Contributor

cjihrig commented Nov 5, 2019

I've gotten feedback from a few folks that "unstable" is confusing. Should we rename "unstable" to "snapshot" while we have a chance here?

Is "current" an option? It's already used in the phases document to describe the thing that transitions to "old."

@sunfishcode
Copy link
Member Author

"snapshot" to me nicely conveys that these are versioned snapshots which are themselves stable, even as WASI evolves. "current" sounds like it might be the tree where the current work is happening, but that's what we call "ephemeral". But I'm happy to follow the sense of the Subgroup.

@sbc100
Copy link
Member

sbc100 commented Nov 5, 2019

snapshot sgtm. I agree it conveys a little more meaning.

@MarkMcCaskey
Copy link

Snapshot sounds good to me too!

When we release a snapshot, it'd be very useful to have a changelog; here's my attempt at making one:

And maybe #136 if it ships

The rest of the changes in the history seem to be bug fixes that were applied to the current unstable, too.

@cjihrig
Copy link
Contributor

cjihrig commented Nov 5, 2019

Follow up question: once a new snapshot is created, what is the best way to know that a corresponding version of wasi-libc is available?

@sunfishcode
Copy link
Member Author

Once we have a snapshot, we'll make the necessary changes to wasi-libc, and then wasi-libc will switch to the snapshot's module name, wasi_unstable_preview0 or wasi_snapshot_preview0 or whatever we call it, so that implementations know which ABI a given wasm module expects.

pchickey pushed a commit that referenced this issue Nov 8, 2019
update phases/README to rename unstable to snapshot
eca6dc9 
Per #138 and discussion on
07nov19 wasi video call.

Updates the steps for PR based on what I did for this first snapshot.
@pchickey pchickey mentioned this issue Nov 8, 2019
Merged
pchickey pushed a commit that referenced this issue Nov 8, 2019
update phases/README to rename unstable to snapshot
39ba594 
Per #138 and discussion on
07nov19 wasi video call.

Updates the steps for PR based on what I did for this first snapshot.
@sunfishcode
Copy link
Member Author

Our story continues in #147.

pchickey pushed a commit that referenced this issue Nov 12, 2019
Create snapshot 1 (#147)
1d1358a 
* archive: contents of `old` moved underneath `snapshot_0`

The contents of `old` are  identical to the current
`unstable/wasi_unstable_preview0` in every sense except the name of the
module and file.

So, for this snapshotting, rather than move the contents of the current
"unstable" (which will be renamed "snapshot" as part of this PR) under a
new directory under phases/old, we're just moving the current contents
under a directory, so that future snapshots can be archived without
changing these paths.

* delete current unstable (snapshot), rather than move it under old.

Special case of this first-time snapshotting process.

* copy phases/ephemeral/* into phases/snapshot/

* rename files in snapshot to snapshot_preview1

* update phases/README to rename `unstable` to `snapshot`

Per #138 and discussion on
07nov19 wasi video call.

Updates the steps for PR based on what I did for this first snapshot.

* witx: tests point at newly snapshotted and archived witx specs

and the test file gets renamed to just regular wasi.rs

* fixes in phases readme per dan's code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create snapshot 1 WebAssembly/WASI
4 participants
@sbc100 @cjihrig @sunfishcode @MarkMcCaskey