Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pops are not valid in Os_print-stack-ir_all-features.wast #3283

Closed
aheejin opened this issue Oct 23, 2020 · 3 comments
Closed

Pops are not valid in Os_print-stack-ir_all-features.wast #3283

aheejin opened this issue Oct 23, 2020 · 3 comments
Assignees
@aheejin

Comments

@aheejin
Copy link
Member

aheejin commented Oct 23, 2020 •
edited
Loading

Currently a pop can only come after a catch, and its argument should be exnref. Os_print-stack-ir_all-features.wast contains tests for pops for various types, so there's no way to make this file a valid wasm file for now. This makes the test not usable as initial content for the fuzzer, and it is in general good to make all our tests valid.

Once the new EH spec is implemented, catch should be able to pop other types values than exnref, then we will be able to make this test valid as well. This is a tracking issue for this problem.
@aheejin aheejin self-assigned this Oct 23, 2020
@aheejin aheejin mentioned this issue Oct 23, 2020
Merged
@tlively
Copy link
Member

tlively commented Oct 23, 2020

It would also be fine to just delete that part of the test. It comes from back when I first implemented Push and Pop with the idea that they could be used anywhere.

@aheejin
Copy link
Member Author

aheejin commented Oct 23, 2020

OK I'll remove the pops from the file then.

aheejin added a commit that referenced this issue Oct 23, 2020
@aheejin
Make pops valid in tests (#3282)
aaf7825 
These two tests had pops in invalid locations; pops are valid only after
`catch`. This fixes those invalid wasm files.
This removes pops from Os_print-stack-ir_all-features.wast too.

Fixes #3213 and #3283.
@aheejin
Copy link
Member Author

aheejin commented Oct 30, 2020

Closed by #3282.

@aheejin aheejin closed this as completed Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aheejin aheejin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tlively @aheejin