Fix misc. tests #2534
Merged
Fix misc. tests #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove a function from memory-packing_all-features.wast, because it does not test anything meaningful after WebAssembly#2529. - Rename a test file to use `--all-features`; it started failing I guess because `exnref` requires also reference type features, but not sure why it was OK so far.
I think it is still OK, it becomes not OK after my pending reference type PR, and I guess my build directory was somehow mixed with the two stuff so it started error out. But anyway, I was gonna do this or in that patch anyway, so. |
tlively
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
does not test anything meaningful after Implement 0-len/drop spec changes in bulk memory #2529.
--all-features; it started failing I guessbecause
exnrefrequires also reference type features, but not surewhy it was OK so far.