Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete test without use #5858

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Delete test without use #5858

merged 1 commit into from
Aug 7, 2023

Conversation

ashleynh
Copy link
Collaborator

@ashleynh ashleynh commented Aug 4, 2023

Thomas said it was okay.

Thomas said it was okay.
@ashleynh ashleynh requested review from kripken and tlively August 4, 2023 21:58
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #5858 (1f6b17a) into main (bcdfa72) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5858   +/-   ##
=======================================
  Coverage   42.45%   42.45%           
=======================================
  Files         482      482           
  Lines       75013    75013           
  Branches    11946    11946           
=======================================
  Hits        31848    31848           
+ Misses      39953    39950    -3     
- Partials     3212     3215    +3     

see 3 files with indirect coverage changes

Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashleynh ashleynh merged commit df45e68 into main Aug 7, 2023
@ashleynh ashleynh deleted the ashleynh-patch-1 branch August 7, 2023 17:43
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
tlively said this test is unused.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants