Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precompute: Check defaultability, not nullability #6052

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Precompute: Check defaultability, not nullability #6052

merged 1 commit into from
Oct 25, 2023

Conversation

kripken
Copy link
Member

@kripken kripken commented Oct 25, 2023

Followup to #6048, we did not handle nondefaultable tuples because of this.

@kripken kripken requested a review from tlively October 25, 2023 20:02
tlively
tlively approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth briefly auditing other uses of isDefaultable for similar issues.

@kripken kripken enabled auto-merge (squash) October 25, 2023 20:11
@kripken kripken merged commit 7a6d962 into main Oct 25, 2023
13 of 14 checks passed
@kripken kripken deleted the fix.fix branch October 25, 2023 20:29
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
@kripken @radekdoulik
Precompute: Check defaultability, not nullability (WebAssembly#6052)
5a71320 
Followup to WebAssembly#6048, we did not handle nondefaultable tuples because of this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlively tlively tlively approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kripken @tlively