[TypeGeneralizing] Properly re-analyze blocks when locals are updated #6081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Whenever the constraint on a local is updated, any block that does a local.set on that global may need to be re-analyzed. Update the TypeGeneralizing transfer function to include these blocks in the set of dependent blocks it returns. Add a test that depends on this logic to validate.
tlively
force-pushed
the
type-generalizing
branch
from
943688d to
ff6e482
Compare
tlively
force-pushed
the
type-generalizing-dependents
branch
from
dbad282 to
f908d96
Compare
|
This is going to be combined into the previous PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the constraint on a local is updated, any block that does a local.set
on that global may need to be re-analyzed. Update the TypeGeneralizing transfer
function to include these blocks in the set of dependent blocks it returns. Add
a test that depends on this logic to validate.