[Parser] Parse call and return_call
#6086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support parsing calls, add support for parsing function indices and building calls with IRBuilder.
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
ashleynh
approved these changes
Nov 7, 2023
| @@ -546,7 +557,14 @@ Result<> IRBuilder::makeBreak(Index label) { | |||
|
|
|||
| // Result<> IRBuilder::makeSwitch() {} | |||
|
|
|||
| // Result<> IRBuilder::makeCall() {} | |||
| Result<> IRBuilder::makeCall(Name func, bool isReturn) { | |||
There was a problem hiding this comment.
Should we add a comment documenting that makeCall is a departure from the wasm-builder.h makeCall, in that there is an assumption the Function already exists before creating the call to it.
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
To support parsing calls, add support for parsing function indices and building calls with IRBuilder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support parsing calls, add support for parsing function indices and building
calls with IRBuilder.