[Parser] Parse br_table #6098
Merged
[Parser] Parse br_table #6098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Nov 10, 2023
ashleynh
reviewed
Nov 13, 2023
| @@ -1200,7 +1200,19 @@ template<typename Ctx> Result<> makeBreak(Ctx& ctx, Index pos) { | |||
| } | |||
|
|
|||
| template<typename Ctx> Result<> makeBreakTable(Ctx& ctx, Index pos) { | |||
| return ctx.in.err("unimplemented instruction"); | |||
| std::vector<typename Ctx::LabelIdxT> labels; | |||
| while (true) { | |||
There was a problem hiding this comment.
I'd add a comment here explaining the logic and the intended outcome of parsing at least one label.
ashleynh
approved these changes
Nov 13, 2023
tlively
force-pushed
the
parser-ref-func
branch
from
1cdd37b to
7f818b5
Compare
tlively
force-pushed
the
parser-br-table
branch
from
6737868 to
92ea14e
Compare
tlively
force-pushed
the
parser-br-table
branch
from
92ea14e to
9ebc017
Compare
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.