Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Outlining] Test single and multivalue return #6120

Merged
merged 9 commits into from
Nov 17, 2023
Merged

[Outlining] Test single and multivalue return #6120

merged 9 commits into from
Nov 17, 2023

Conversation

ashleynh
Copy link
Collaborator

Adds a test that:

  • creates an outlined function that returns a single value
  • creates an outlined function that returns multivalue

@ashleynh ashleynh requested a review from tlively November 14, 2023 05:50
tlively
tlively reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments from previous PRs.

@ashleynh ashleynh force-pushed the filter_tests branch 2 times, most recently from 20f4260 to 932048f Compare November 17, 2023 00:07
Base automatically changed from filter_tests to main November 17, 2023 01:44
@ashleynh ashleynh requested a review from tlively November 17, 2023 02:36
@ashleynh ashleynh merged commit 67f2fdc into main Nov 17, 2023
14 checks passed
@ashleynh ashleynh deleted the multi_return branch November 17, 2023 05:03
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
@ashleynh @radekdoulik
[Outlining] Test single and multivalue return (WebAssembly#6120)
5180f87 
Adds two tests, creates an outlined function that returns a single value and creates an outlined function that returns multivalue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlively tlively tlively approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashleynh @tlively