SignatureRefining: Notice LUB requirements of intrinsic calls #6122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Nov 15, 2023
Comment on lines
+989
to
+991
| ;; Test we consider call.without.effects when deciding what to refine. $A has | ||
| ;; two subtypes, B1 and B2, and a call.without.effects sends in one while a | ||
| ;; normal call sends in the other. As a result, we cannot refine to either. |
There was a problem hiding this comment.
It would be nice to additionally test that the refinement can still happen if there is a call without effects involved and the types work out.
There was a problem hiding this comment.
Sounds good. I'll start automerge now as I am gone for the evening and want to get this on the way for the user that hit it, and will open a followup PR tomorrow with that extra test.
tlively
approved these changes
Nov 15, 2023
kripken
added a commit
that referenced
this pull request
Nov 15, 2023
kripken
added a commit
that referenced
this pull request
Nov 16, 2023
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
…embly#6122) call.without.effects implies a call to the function reference in the last parameter, so the values sent in the other parameters must be taken into account when computing LUBs for refining arguments, otherwise we might refine so much that the intrinsic call no longer validates.
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
call.without.effectsimplies a call to the function reference in the last parameter,so the values sent in the other parameters must be taken into account when
computing LUBs for refining arguments, otherwise we might refine so much that
the intrinsic call no longer validates.