Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use clang 15 to avoid ASan test flakes that 14 has #6125

Merged
merged 8 commits into from
Nov 16, 2023
Merged

Use clang 15 to avoid ASan test flakes that 14 has #6125

merged 8 commits into from
Nov 16, 2023

Conversation

kripken
Copy link
Member

@kripken kripken commented Nov 16, 2023 •
edited
Loading

see #6116

@kripken kripken marked this pull request as ready for review November 16, 2023 21:35
@kripken
Copy link
Member Author

kripken commented Nov 16, 2023

This seems to fix these annoying flakes on the asan tests. Those tests passed 5 times in a row here using clang 15, while with clang 14 (as on main) pretty much every run has been failing for me these last few days...

@kripken kripken mentioned this pull request Nov 16, 2023
Closed
@kripken kripken changed the title Try newer clang to see if asan error shows up Use clang 15 to avoid ASan test flakes that 14 has Nov 16, 2023
tlively
tlively approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice in theory to have a unified mechanism for installing LLVM between the lint runner and the asan runner, but using this action does seem more convenient and the docs don't mention it installing any of the tools the lint runner needs.

@kripken
Copy link
Member Author

kripken commented Nov 16, 2023

Landing. If we see this error come up again then we can back this out.

@kripken kripken merged commit b43b70d into main Nov 16, 2023
14 checks passed
@kripken kripken deleted the newer.clang branch November 16, 2023 22:38
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
@kripken @radekdoulik
Use clang 15 to avoid ASan test flakes that 14 has (WebAssembly#6125)
4de9c86 
Seems to fix WebAssembly#6116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlively tlively tlively approved these changes

@ashleynh ashleynh Awaiting requested review from ashleynh

@aheejin aheejin Awaiting requested review from aheejin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kripken @tlively