[Parser] Parse tags and throw #6126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
tlively
force-pushed
the
parser-tag-throw
branch
from
d583b60 to
687b078
Compare
When branches target control flow structures other than blocks or loops, the IRBuilder wraps those control flow structures with an extra block for the branches to target in Binaryen IR. Usually that block has the same type as the control flow structure it wraps, but when the control flow structure is unreachable because all its bodies are unreachable, the wrapper block may still need to have a non-unreachable type if it is targeted by branches. Previously the wrapper block would also be unreachable in that case. Fix the bug by tracking whether the wrapper block will be targeted by any branches and use the control flow structure's original, non-unreachable type if so.
Also fix the parser to correctly error if an imported item appears after a non-imported item and make the corresponding fix to the test.
tlively
force-pushed
the
parser-tag-throw
branch
from
687b078 to
be8295c
Compare
ashleynh
reviewed
Nov 21, 2023
| ;; CHECK-NEXT: ) | ||
| ;; CHECK-NEXT: ) | ||
| (func $throw | ||
| throw 2 |
There was a problem hiding this comment.
How did throw de bruijn 2 become $1?
There was a problem hiding this comment.
talked offline: not a de bruijn idx, but a tag idx.
ashleynh
approved these changes
Nov 21, 2023
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Also fix the parser to correctly error if an imported item appears after a non-imported item and make the corresponding fix to the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix the parser to correctly error if an imported item appears after a
non-imported item and make the corresponding fix to the test.