binaryen.js: Remove closure flags that set the ES version #6157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Dec 8, 2023
sbc100
reviewed
Dec 8, 2023
| @@ -468,7 +468,6 @@ if(EMSCRIPTEN) | |||
| target_link_libraries(binaryen_wasm "-msign-ext") | |||
There was a problem hiding this comment.
I think sign-ext is the default these days so you can probably remove this line too
|
Hmm, this still errors, so that wasn't it. Any other theories @sbc100 ? edit: I'm investigating locally |
|
I see the correct flags in there |
|
I bisected the regression to "Leverage coalescing operators. NFC emscripten-core/emscripten#20531" |
|
I also may have found the problem here, those flags were in a second place. edit: Locally that last commit fixes it. |
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
…y#6157) Emscripten sets that itself these days.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emscripten sets that itself these days.