[test] Fix wasm2js stale check failure #6168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to exclude wasm2js asserts tests from `check_for_stale_files` in WebAssembly#6164, but ended up doing it incorrectly. The file I checked for was `wasm2js.wast.asserts`, while the output I should have excluded was `wasm2js.asserts.js`. This fixes the code so we now check the prefix and not the filename. This is currently breaking the main branch, which was caused by me landing multiple PRs at once. Sorry for the breakage. Landing this will fix it.
kripken
approved these changes
Dec 12, 2023
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
I tried to exclude wasm2js asserts tests from `check_for_stale_files` in WebAssembly#6164, but ended up doing it incorrectly. The file I checked for was `wasm2js.wast.asserts`, while the output I should have excluded was `wasm2js.asserts.js`. This fixes the code so we now check the prefix and not the filename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to exclude wasm2js asserts tests from
check_for_stale_filesin #6164, but ended up doing it incorrectly. The file I checked for waswasm2js.wast.asserts, while the output I should have excluded waswasm2js.asserts.js. This fixes the code so we now check the prefix and not the filename.This is currently breaking the main branch, which was caused by me landing multiple PRs at once. Sorry for the breakage. Landing this will fix it.