Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parser] Parse tuple operations #6174

Merged
merged 1 commit into from
Dec 13, 2023
Merged

[Parser] Parse tuple operations #6174

merged 1 commit into from
Dec 13, 2023

Conversation

tlively
Copy link
Member

@tlively tlively commented Dec 13, 2023

Parse tuple.make, tuple.extract, and tuple.drop. Also slightly improve the
way we break up tuples into individual elements in IRBuilder by using a
local.tee instead of a block containing a local.set and local.get.

@tlively tlively requested a review from kripken December 13, 2023 05:30
@tlively
Copy link
Member Author

tlively commented Dec 13, 2023

@tlively tlively force-pushed the irbuilder-multivalue-drop branch from 265d280 to 19a89ad Compare December 13, 2023 19:14
@tlively tlively force-pushed the parser-tuple-ops branch 3 times, most recently from b17fb6e to 3234bd4 Compare December 13, 2023 20:22
Base automatically changed from irbuilder-multivalue-drop to main December 13, 2023 22:05
Parse `tuple.make`, `tuple.extract`, and `tuple.drop`. Also slightly improve the
way we break up tuples into individual elements in IRBuilder by using a
`local.tee` instead of a block containing a `local.set` and `local.get`.
@tlively tlively merged commit 7adc82b into main Dec 13, 2023
27 checks passed
@tlively tlively deleted the parser-tuple-ops branch December 13, 2023 23:50
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
Parse `tuple.make`, `tuple.extract`, and `tuple.drop`. Also slightly improve the
way we break up tuples into individual elements in IRBuilder by using a
`local.tee` instead of a block containing a `local.set` and `local.get`.
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants