Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect validation of segment sizes #6228

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

kripken
Copy link
Member

@kripken kripken commented Jan 18, 2024

This should be a runtime error, not a validator error. It caused a fuzzer failure on
wasm-ctor-eval.

@kripken kripken requested a review from tlively January 18, 2024 21:40
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This runtime error was introduced in the bulk memory proposal. Before that, OOB offsets were indeed validation errors. It's probably not worth having two code paths for this, though.

@kripken kripken merged commit 459e0d2 into WebAssembly:main Jan 22, 2024
14 checks passed
@kripken kripken deleted the valfix branch January 22, 2024 17:53
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
This should be a runtime error, not a validator error. It caused a fuzzer failure on
wasm-ctor-eval.
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants