[Parser] Parse throw_ref #6238
Merged
[Parser] Parse throw_ref #6238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
18 tasks
kripken
approved these changes
Jan 25, 2024
aheejin
approved these changes
Jan 25, 2024
src/parser/contexts.h
Outdated
| @@ -1406,7 +1407,9 @@ struct ParseDefsCtx : TypeParserCtx<ParseDefsCtx> { | |||
| irBuilder.makeTry(label ? *label : Name{}, type.getSignature().results)); | |||
| } | |||
|
|
|||
| Result<> makeTryTable(Index pos, std::optional<Name> label, HeapType type, | |||
| Result<> makeTryTable(Index pos, | |||
There was a problem hiding this comment.
It looks try_table related code has several formatting changes here in this PR. Were they meant to be in #6237 instead?
src/wasm.h
Outdated
| @@ -1522,6 +1522,7 @@ class Rethrow : public SpecificExpression<Expression::RethrowId> { | |||
| // 'throw_ref' from the new EH proposal | |||
| class ThrowRef : public SpecificExpression<Expression::ThrowRefId> { | |||
| public: | |||
| ThrowRef() {} | |||
There was a problem hiding this comment.
Suggested change
| ThrowRef() {} | |
| ThrowRef() = default; |
Nit: It looks other classes in this file use this
tlively
force-pushed
the
parser-throw-ref
branch
from
f32159b to
0f2afb7
Compare
tlively
force-pushed
the
parser-throw-ref
branch
from
0f2afb7 to
ce1908e
Compare
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.