Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get more tests working with the new text parser #6284

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Get more tests working with the new text parser #6284

merged 1 commit into from
Feb 7, 2024

Conversation

tlively
Copy link
Member

@tlively tlively commented Feb 7, 2024

The new parser enforces the rule that imports must come before declarations
(except for type declarations). The old parser does not enforce this rule, so
many of our tests did not follow it. Fix them to follow that rule and fix other
invalid syntax. Also add missing finalization of Load expressions in
wasm-builder.h that was causing a test to fail under the new parser and guard
against an error case in wasm-ir-builder.cpp that used to cause a segfault.

The new parser enforces the rule that imports must come before declarations
(except for type declarations). The old parser does not enforce this rule, so
many of our tests did not follow it. Fix them to follow that rule and fix other
invalid syntax. Also add missing finalization of Load expressions in
wasm-builder.h that was causing a test to fail under the new parser and guard
against an error case in wasm-ir-builder.cpp that used to cause a segfault.
@tlively tlively requested a review from kripken February 7, 2024 22:09
@tlively
Copy link
Member Author

tlively commented Feb 7, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@tlively tlively merged commit d4c3fdd into main Feb 7, 2024
15 checks passed
@tlively tlively deleted the test-fixes branch February 7, 2024 23:04
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
The new parser enforces the rule that imports must come before declarations
(except for type declarations). The old parser does not enforce this rule, so
many of our tests did not follow it. Fix them to follow that rule and fix other
invalid syntax. Also add missing finalization of Load expressions in
wasm-builder.h that was causing a test to fail under the new parser and guard
against an error case in wasm-ir-builder.cpp that used to cause a segfault.
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants