Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzer: Ignore V8 errors on uninitialized non-defaultable locals #6337

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

kripken
Copy link
Member

@kripken kripken commented Feb 22, 2024

See #5665 #5599, this is an existing issue and we have a workaround for it
using --dce, but it does not always work. I seem to be seeing this in higher
frequency since landing recent fuzzer improvements, so ignore it.

There is some risk of us missing real bugs here (that we validate and V8
does not), but this is a validation error which is not as serious as a difference
in behavior. And this is a long-standing issue that hasn't bitten us yet.

@kripken kripken requested a review from tlively February 22, 2024 21:59
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth printing a warning or something for these ignored issues, just to keep them top of mind and maybe motivate us to fix them at some point?

@kripken
Copy link
Member Author

kripken commented Feb 22, 2024

Maybe we should do more for that, yeah. The amount ignored is reported, e.g.

ITERATION: 12884 seed: 14203204938912432813 size: 8923
(mean: 40738.996352064576, stddev: 26835.6222677628)
speed: 2.0233051433240834 iters/sec,  68669.57184038128
wasm_bytes/sec,  387 ignored                                                                                                                                                                                            

So we ignored 387 out of 12,884 there. But we could also report a breakdown of the reason for each ignored issue perhaps.

@kripken kripken merged commit dabfd5b into WebAssembly:main Feb 22, 2024
14 checks passed
@kripken kripken deleted the nondef.fuzz branch February 22, 2024 23:39
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
…Assembly#6337)

See WebAssembly#5665 WebAssembly#5599, this is an existing issue and we have a workaround for it
using --dce, but it does not always work. I seem to be seeing this in higher
frequency since landing recent fuzzer improvements, so ignore it.

There is some risk of us missing real bugs here (that we validate and V8
does not), but this is a validation error which is not as serious as a difference
in behavior. And this is a long-standing issue that hasn't bitten us yet.
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants