[Parser] Use unreachables to fulfill tuple requirements #6488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 11, 2024
kripken
reviewed
Apr 11, 2024
| @@ -175,7 +175,7 @@ Result<Expression*> IRBuilder::pop(size_t size) { | |||
| CHECK_ERR(packageHoistedValue(*hoisted, size)); | |||
|
|
|||
| auto* ret = scope.exprStack.back(); | |||
| if (ret->type.size() == size) { | |||
| if (ret->type.size() == size || ret->type == Type::unreachable) { | |||
There was a problem hiding this comment.
From your description I thought this was for tuples, but ret->type.size() == size can be the case for non-tuples too, can't it? (when size == 1)
There was a problem hiding this comment.
Yes, but since we report the size of Type::unreachable as 1, this code path was already taken for singular unreachable popped values.
There was a problem hiding this comment.
I see, thanks. Maybe worth a comment?
When we need to pop a tuple and the top value on the stack is unreachable, just pop the unreachable rather than producing a tuple.make. This always produces valid IR since an unreachable is always valid where a tuple would otherwise be expected. It also avoids bloating the parsed IR, since we would previously parse a `tuple.make` where all the children were unreachable in this case.
kripken
approved these changes
Apr 11, 2024
tlively
force-pushed
the
parser-pop-unreachable-tuple
branch
from
f64f57d to
59c021e
Compare
18 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we need to pop a tuple and the top value on the stack is unreachable, just
pop the unreachable rather than producing a tuple.make. This always produces
valid IR since an unreachable is always valid where a tuple would otherwise be
expected. It also avoids bloating the parsed IR, since we would previously parse
a
tuple.makewhere all the children were unreachable in this case.