[NFC] Move enough of wasm-type.cpp into wasm-type.h to inline core is*() methods #6936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Sep 13, 2024
Comment on lines
+264
to
+265
| // Internal only. | ||
| struct TypeInfo { |
There was a problem hiding this comment.
Can we put this and the method implementations that use it into a separate wasm-type-impl.h?
There was a problem hiding this comment.
Interesting idea! It sounds like it would require at least 3 headers, though:
- One header for HeapType.
- One header for TypeInfo, which depends on HeapType (even a forward declaration is insufficient).
- One header for the rest of wasm-type.h
I'm not sure if that much splitting is worth it?
tlively
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just moves code around. As a result,
isRef()vanishes entirely from theprofiling traces in #6931, since now the core
isRef/Tuple/etc.methods areall inlineable.
This also required some reordering of
wasm-type.h, namely to move HeapTypeup front. No changes to that class otherwise.
TypeInfois now in the header.getTypeInfois now a static method onType.This has the downside of moving internal details into the header, but it
doesn't seem that dangerous to me. Another downside is that it will add to
compile times of Binaryen itself. But this makes the
--precomputebenchmarkfrom #6931 significantly faster, 33%, so I think it is worth it.