[NFC] Add isSSA to LazyLocalGraph, and use it in OptimizeAddedConstants #6952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Sep 18, 2024
src/ir/local-graph.h
Outdated
| bool isSSA(Index index) const { | ||
| auto iter = SSAIndexes.find(index); | ||
| if (iter == SSAIndexes.end()) { | ||
| computeSSA(index); |
There was a problem hiding this comment.
Might as well have computeSSA return the result so we don't need to do another lookup afterward.
There was a problem hiding this comment.
Makes sense, done. It does make it stand out from the others, but in this case the code is simpler and more efficient.
| } | ||
| } | ||
| for (auto* get : flower->getsByIndex[index]) { | ||
| for (auto* set : getSets(get)) { |
There was a problem hiding this comment.
How can looking at the sets for a get find sets that weren't already found by looking directly at the sets above?
There was a problem hiding this comment.
The gets may also be reading from nullptr (the value at the function entry, for which there is no LocalSet).
tlively
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the pass 15% faster.