Fix BranchUtils::operateOnScopeNameUsesAndSentValues() on BrOn #6995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aheejin
approved these changes
Oct 10, 2024
| ;; CHECK-NEXT: (block | ||
| ;; CHECK-NEXT: (drop | ||
| ;; CHECK-NEXT: (br_on_null $loop | ||
| ;; CHECK-NEXT: (ref.null none) |
There was a problem hiding this comment.
Why has any changed to none? Does GUFA do that?
There was a problem hiding this comment.
This is actually something we do automatically all the time (I forgot if in refinalize or in parsing, but one of them). Basically we turn nulls into the most refined types that we can, of the bottom type, because that is always valid and more precise.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BrOn does not always send a value. This is an odd asymmetry in the wasm
spec, where
br_on_nulldoes not send the null on the branch (which makes sense,but the asymmetry does mean we need to special-case it).
Found by fuzzing with some BrOn additions that I will open a PR for later.