Special-case empty { ... } sequences for prettier name mangling.
#104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current mangling for eg. records:
```python
return 'record { ' + ', '.join(mangled_fields) + ' }'
```
the mangling for a record with 0 fields is `record { }`, with two
spaces between the braces. That looks subjectively surprising.
This PR adds special cases to the mangling for `record` and similar
types so that the mangling is `record {}`, with no spaces between the
braces, which is subjectively prettier.
The argument against this is that empty records should be very rare,
so prettiness isn't important, and every special case makes the system
more complex. The argument for it is that a mangling with two spaces
looks weird.
sunfishcode
added a commit
to sunfishcode/wit-bindgen
that referenced
this pull request
Sep 12, 2022
This implements the name-mangling scheme in the current canonical ABI, with the modification proposed in WebAssembly/component-model#104, though that can be easily removed if the proposal is declined.
sunfishcode
added a commit
to bytecodealliance/wit-bindgen
that referenced
this pull request
Sep 12, 2022
* Rename `canonical_abi_realloc` to `cabi_realloc`. This follows the current Canonical ABI. This doesn't rename `canonical_abi_free`, as that's expected to be removed when post-return functions are implemented. * Rename the "expected" type to "result". This follows the current Canonical ABI. * Implement function and value type name mangling. This implements the name-mangling scheme in the current canonical ABI, with the modification proposed in WebAssembly/component-model#104, though that can be easily removed if the proposal is declined. * Use name mangling in the bindings generators. * Use the export base name rather than the mangled name for python identifiers.
|
This is ultimately a subjective matter, but to me this seems to add more special cases than warranted by the frequency and degree of benefit to humans. ¯_(ツ)_/¯ |
|
¯_(ツ)_/¯ |
sunfishcode
added a commit
to sunfishcode/wit-bindgen
that referenced
this pull request
Sep 13, 2022
WebAssembly/component-model#104 is closed, so remove the corresponding special case from wit-bindgen too.
sunfishcode
added a commit
to bytecodealliance/wit-bindgen
that referenced
this pull request
Sep 13, 2022
* Remove the special case for empty records. WebAssembly/component-model#104 is closed, so remove the corresponding special case from wit-bindgen too. * Update unit tests.
alexcrichton
pushed a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Nov 16, 2022
* Rename `canonical_abi_realloc` to `cabi_realloc`. This follows the current Canonical ABI. This doesn't rename `canonical_abi_free`, as that's expected to be removed when post-return functions are implemented. * Rename the "expected" type to "result". This follows the current Canonical ABI. * Implement function and value type name mangling. This implements the name-mangling scheme in the current canonical ABI, with the modification proposed in WebAssembly/component-model#104, though that can be easily removed if the proposal is declined. * Use name mangling in the bindings generators. * Use the export base name rather than the mangled name for python identifiers.
alexcrichton
pushed a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Nov 16, 2022
* Remove the special case for empty records. WebAssembly/component-model#104 is closed, so remove the corresponding special case from wit-bindgen too. * Update unit tests.
alexcrichton
pushed a commit
to alexcrichton/wasmtime-py
that referenced
this pull request
Nov 16, 2022
* Rename `canonical_abi_realloc` to `cabi_realloc`. This follows the current Canonical ABI. This doesn't rename `canonical_abi_free`, as that's expected to be removed when post-return functions are implemented. * Rename the "expected" type to "result". This follows the current Canonical ABI. * Implement function and value type name mangling. This implements the name-mangling scheme in the current canonical ABI, with the modification proposed in WebAssembly/component-model#104, though that can be easily removed if the proposal is declined. * Use name mangling in the bindings generators. * Use the export base name rather than the mangled name for python identifiers.
guybedford
pushed a commit
to bytecodealliance/jco
that referenced
this pull request
Dec 17, 2022
* Rename `canonical_abi_realloc` to `cabi_realloc`. This follows the current Canonical ABI. This doesn't rename `canonical_abi_free`, as that's expected to be removed when post-return functions are implemented. * Rename the "expected" type to "result". This follows the current Canonical ABI. * Implement function and value type name mangling. This implements the name-mangling scheme in the current canonical ABI, with the modification proposed in WebAssembly/component-model#104, though that can be easily removed if the proposal is declined. * Use name mangling in the bindings generators. * Use the export base name rather than the mangled name for python identifiers.
guybedford
pushed a commit
to bytecodealliance/jco
that referenced
this pull request
Dec 17, 2022
* Rename `canonical_abi_realloc` to `cabi_realloc`. This follows the current Canonical ABI. This doesn't rename `canonical_abi_free`, as that's expected to be removed when post-return functions are implemented. * Rename the "expected" type to "result". This follows the current Canonical ABI. * Implement function and value type name mangling. This implements the name-mangling scheme in the current canonical ABI, with the modification proposed in WebAssembly/component-model#104, though that can be easily removed if the proposal is declined. * Use name mangling in the bindings generators. * Use the export base name rather than the mangled name for python identifiers.
guybedford
pushed a commit
to bytecodealliance/jco
that referenced
this pull request
Dec 21, 2022
* Rename `canonical_abi_realloc` to `cabi_realloc`. This follows the current Canonical ABI. This doesn't rename `canonical_abi_free`, as that's expected to be removed when post-return functions are implemented. * Rename the "expected" type to "result". This follows the current Canonical ABI. * Implement function and value type name mangling. This implements the name-mangling scheme in the current canonical ABI, with the modification proposed in WebAssembly/component-model#104, though that can be easily removed if the proposal is declined. * Use name mangling in the bindings generators. * Use the export base name rather than the mangled name for python identifiers.
rvolosatovs
pushed a commit
to bytecodealliance/wrpc
that referenced
this pull request
May 23, 2024
* Rename `canonical_abi_realloc` to `cabi_realloc`. This follows the current Canonical ABI. This doesn't rename `canonical_abi_free`, as that's expected to be removed when post-return functions are implemented. * Rename the "expected" type to "result". This follows the current Canonical ABI. * Implement function and value type name mangling. This implements the name-mangling scheme in the current canonical ABI, with the modification proposed in WebAssembly/component-model#104, though that can be easily removed if the proposal is declined. * Use name mangling in the bindings generators. * Use the export base name rather than the mangled name for python identifiers.
rvolosatovs
pushed a commit
to bytecodealliance/wrpc
that referenced
this pull request
May 23, 2024
* Remove the special case for empty records. WebAssembly/component-model#104 is closed, so remove the corresponding special case from wit-bindgen too. * Update unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current mangling for eg. records:
the mangling for a record with 0 fields is
record { }, with two spaces between the braces. That looks subjectively surprising.This PR adds special cases to the mangling for
recordand similar types so that the mangling isrecord {}, with no spaces between the braces, which is subjectively prettier.The argument against this is that empty records should be very rare, so prettiness isn't important, and every special case makes the system more complex. The argument for it is that a mangling with two spaces looks weird.